Refactoring entities (#23)

* Still WIP

* WIP

* ArrayEntity parsing fixed

* Fix format text entity

* Tests for various entity classes and update entity class implementations

* More tests and fixed

* More entities fixed

* Simple entities serialization fixed

* Entities tests fixed

* Remove serialization bits

* Fix Function reference

* CustomProperties creating fixed

* WIP

* Better typing for grammars

* Decoding code fixes

* Fixing still

* Several fixes

* rename toString to serialize

* Several fixes

* More fixes

* Moving more stuff out of Utility

* Several fixes

* Fixing Linear color entity print

* Serialization fixes

* Fix serialization

* Method to compute grammar

* Renaming fix

* Fix array grammar and equality check

* Fix inlined keys

* Fix type

* Several serialization fixes

* Fix undefined dereference

* Several fixes

* More fixes and cleanup

* Fix keys quoting mechanism

* Fix natural number assignment

* Fix Int64 toString()

* Fix quoted keys for inlined arrays

* Fix PG pins

* Fix several test cases

* Types fixes

* New pin default value empty

* Fix non existing DefaultValue for variadic nodes

* Smaller fixes for crashes

* Fix link color when attached to knot

* Linking test and more reliability operations for adding pins

* Improve issue 18 test

* More tests and fixes

* Fix enum pin entity

* Remove failing test

js/entity/SimpleSerializationRotatorEntity.js

@@ -1,25 +1,41 @@
-import Parsernostrum from "parsernostrum"
+import P from "parsernostrum"
+import NumberEntity from "./NumberEntity.js"
 import RotatorEntity from "./RotatorEntity.js"
 
 export default class SimpleSerializationRotatorEntity extends RotatorEntity {
 
+    static attributeSeparator = ", "
     static grammar = this.createGrammar()
 
     static createGrammar() {
-        const number = Parsernostrum.number.getParser().parser.regexp.source
-        return Parsernostrum.alt(
-            Parsernostrum.regArray(new RegExp(
-                "(" + number + ")"
-                + "\\s*,\\s*"
-                + "(" + number + ")"
-                + "\\s*,\\s*"
-                + "(" + number + ")"
-            )).map(([_, p, y, r]) => new this({
-                R: Number(r),
-                P: Number(p),
-                Y: Number(y),
-            })),
-            RotatorEntity.grammar
+        return /** @type {P<SimpleSerializationRotatorEntity>} */(
+            P.alt(
+                P.regArray(new RegExp(
+                    `(${NumberEntity.numberRegexSource})`
+                    + String.raw`\s*,\s*`
+                    + `(${NumberEntity.numberRegexSource})`
+                    + String.raw`\s*,\s*`
+                    + `(${NumberEntity.numberRegexSource})`
+                )).map(([_, p, pPrecision, y, yPrecision, r, rPrecision]) => new this({
+                    R: new (RotatorEntity.attributes.R)(r, rPrecision?.length),
+                    P: new (RotatorEntity.attributes.P)(p, pPrecision?.length),
+                    Y: new (RotatorEntity.attributes.Y)(y, yPrecision?.length),
+                })),
+                RotatorEntity.grammar.map(v => new this({
+                    R: v.R,
+                    P: v.P,
+                    Y: v.Y,
+                }))
+            ).label("SimpleSerializationRotatorEntity")
         )
     }
+
+    doSerialize() {
+        const attributeSeparator = /** @type {typeof SimpleSerializationRotatorEntity} */(
+            this.constructor
+        ).attributeSeparator
+        return this.P.serialize() + attributeSeparator
+            + this.Y.serialize() + attributeSeparator
+            + this.R.serialize() + (this.trailing ? attributeSeparator : "")
+    }
 }