diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts index 501741a6..2766a92d 100644 --- a/__tests__/main.test.ts +++ b/__tests__/main.test.ts @@ -14,6 +14,12 @@ import * as main from '../src/main'; import * as util from '../src/util'; import OfficialBuilds from '../src/distributions/official_builds/official_builds'; +import * as installerFactory from '../src/distributions/installer-factory'; +jest.mock('../src/distributions/installer-factory', () => ({ + getNodejsDistribution: jest.fn() +})); +import {validateMirrorURL} from '../src/util'; + describe('main tests', () => { let inputs = {} as any; let os = {} as any; @@ -38,6 +44,8 @@ describe('main tests', () => { let setupNodeJsSpy: jest.SpyInstance; + let validateMirrorUrlSpy: jest.SpyInstance; + beforeEach(() => { inputs = {}; @@ -165,6 +173,8 @@ describe('main tests', () => { }); }); + + describe('node-version-file flag', () => { beforeEach(() => { delete inputs['node-version']; @@ -280,4 +290,6 @@ describe('main tests', () => { ); }); }); + + }); diff --git a/__tests__/official-installer.test.ts b/__tests__/official-installer.test.ts index 2d8f17cf..9f81b940 100644 --- a/__tests__/official-installer.test.ts +++ b/__tests__/official-installer.test.ts @@ -10,6 +10,8 @@ import osm from 'os'; import path from 'path'; import * as main from '../src/main'; import * as auth from '../src/authutil'; +import isLtsAlias from '../src/distributions/official_builds/official_builds'; + import OfficialBuilds from '../src/distributions/official_builds/official_builds'; import {INodeVersion} from '../src/distributions/base-models'; @@ -828,4 +830,80 @@ describe('setup-node', () => { } ); }); + describe('mirror-url parameter', () => { + it('Download mirror url if mirror-url is provided', async () => { + // Set up test inputs and environment + os.platform = 'linux'; + os.arch = 'x64'; + inputs['check-latest'] = 'true'; + const mirrorURL = (inputs['mirror-url'] = + 'https://custom-mirror-url.com'); + inputs['token'] = 'faketoken'; + + // Mock that the version is not in cache (simulate a fresh download) + findSpy.mockImplementation(() => ''); + + // Mock implementations for other dependencies + const toolPath = path.normalize('/cache/node/11.11.0/x64'); + exSpy.mockImplementation(async () => '/some/other/temp/path'); + cacheSpy.mockImplementation(async () => toolPath); + + const dlmirrorSpy = jest.fn(); // Create a spy to track the download logic + + const mockDownloadNodejs = jest + .spyOn(OfficialBuilds.prototype as any, 'downloadFromMirrorURL') + .mockImplementation(async () => { + dlmirrorSpy(); + }); + + // Run the main method or your logic that invokes `downloadFromMirrorURL` + await main.run(); // This should internally call `downloadFromMirrorURL` + + // Prepare the expected path after download + const expPath = path.join(toolPath, 'bin'); + + // Assert that the spy was called, meaning the download logic was triggered + expect(dlmirrorSpy).toHaveBeenCalled(); // This verifies that the download occurred + + // Other assertions to verify the flow + expect(exSpy).toHaveBeenCalled(); + expect(logSpy).toHaveBeenCalledWith( + `Attempting to download from ${mirrorURL}...` + ); + expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`); + + // Clean up mocks after the test + mockDownloadNodejs.mockRestore(); // Ensure to restore the original method after the test + }); + + it('fallback to default if mirror url is not provided', async () => { + os.platform = 'linux'; + os.arch = 'x64'; + + inputs['node-version'] = '11'; + inputs['check-latest'] = 'true'; + inputs['always-auth'] = false; + inputs['token'] = 'faketoken'; + + dlSpy.mockImplementation(async () => '/some/temp/path'); + const toolPath = path.normalize('/cache/node/12.11.0/x64'); + exSpy.mockImplementation(async () => '/some/other/temp/path'); + cacheSpy.mockImplementation(async () => toolPath); + + const dlmirrorSpy = jest.fn(); + dlmirrorSpy.mockImplementation(async () => 'mocked-download-path'); + await main.run(); + + const expPath = path.join(toolPath, 'bin'); + + expect(dlSpy).toHaveBeenCalled(); + expect(exSpy).toHaveBeenCalled(); + + expect(logSpy).toHaveBeenCalledWith( + 'Attempt to resolve the latest version from manifest...' + ); + + expect(cnSpy).toHaveBeenCalledWith(`::add-path::${expPath}${osm.EOL}`); + }); + }); }); diff --git a/action.yml b/action.yml index 99db5869..45cadd5f 100644 --- a/action.yml +++ b/action.yml @@ -16,6 +16,9 @@ inputs: default: false registry-url: description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.' + mirror-url: + description: 'Custom mirror URL to download Node.js from (optional)' + required: false scope: description: 'Optional scope for authenticating against scoped registries. Will fall back to the repository owner when using the GitHub Packages registry (https://npm.pkg.github.com/).' token: diff --git a/dist/cache-save/index.js b/dist/cache-save/index.js index 9d8d1980..c429901f 100644 --- a/dist/cache-save/index.js +++ b/dist/cache-save/index.js @@ -91098,7 +91098,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) { return (mod && mod.__esModule) ? mod : { "default": mod }; }; Object.defineProperty(exports, "__esModule", ({ value: true })); -exports.unique = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0; +exports.unique = exports.validateMirrorURL = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0; const core = __importStar(__nccwpck_require__(2186)); const exec = __importStar(__nccwpck_require__(1514)); const io = __importStar(__nccwpck_require__(7436)); @@ -91186,6 +91186,15 @@ function getToolVersion(tool, options) { } }); } +function validateMirrorURL(mirrorURL) { + if (mirrorURL === ' ' || mirrorURL.trim() === 'undefined') { + throw new Error('Mirror URL is empty. Please provide a valid mirror URL.'); + } + else { + return mirrorURL; + } +} +exports.validateMirrorURL = validateMirrorURL; const unique = () => { const encountered = new Set(); return (value) => { diff --git a/dist/setup/index.js b/dist/setup/index.js index cdca1dbf..e4c17a2e 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -100154,6 +100154,32 @@ class BaseDistribution { return response.result || []; }); } + getMirrorUrlVersions() { + return __awaiter(this, void 0, void 0, function* () { + const initialUrl = this.getDistributionUrl(); + const dataUrl = `${initialUrl}/index.json`; + try { + const response = yield this.httpClient.getJson(dataUrl); + return response.result || []; + } + catch (err) { + if (err instanceof Error && + err.message.includes('getaddrinfo EAI_AGAIN')) { + core.error(`Network error: Failed to resolve the server at ${dataUrl}. + Please check your DNS settings or verify that the URL is correct.`); + } + else if (err instanceof hc.HttpClientError && err.statusCode === 404) { + core.error(`404 Error: Unable to find versions at ${dataUrl}. + Please verify that the mirror URL is valid.`); + } + else { + core.error(`Failed to fetch Node.js versions from ${dataUrl}. + Please check the URL and try again.}`); + } + throw err; + } + }); + } getNodejsDistInfo(version) { const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); version = semver_1.default.clean(version) || ''; @@ -100174,6 +100200,26 @@ class BaseDistribution { fileName: fileName }; } + getNodejsMirrorURLInfo(version) { + const mirrorURL = this.nodeInfo.mirrorURL; + const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); + version = semver_1.default.clean(version) || ''; + const fileName = this.osPlat == 'win32' + ? `node-v${version}-win-${osArch}` + : `node-v${version}-${this.osPlat}-${osArch}`; + const urlFileName = this.osPlat == 'win32' + ? this.nodeInfo.arch === 'arm64' + ? `${fileName}.zip` + : `${fileName}.7z` + : `${fileName}.tar.gz`; + const url = `${mirrorURL}/v${version}/${urlFileName}`; + return { + downloadUrl: url, + resolvedVersion: version, + arch: osArch, + fileName: fileName + }; + } downloadNodejs(info) { return __awaiter(this, void 0, void 0, function* () { let downloadPath = ''; @@ -100185,8 +100231,15 @@ class BaseDistribution { if (err instanceof tc.HTTPError && err.httpStatusCode == 404 && this.osPlat == 'win32') { - return yield this.acquireWindowsNodeFromFallbackLocation(info.resolvedVersion, info.arch); + return yield this.acquireWindowsNodeFromFallbackLocation(info.resolvedVersion, info.arch, info.downloadUrl); } + // Handle network-related issues (e.g., DNS resolution failures) + if (err instanceof Error && + err.message.includes('getaddrinfo EAI_AGAIN')) { + core.error(`Network error: Failed to resolve the server at ${info.downloadUrl}. + This could be due to a DNS resolution issue. Please verify the URL or check your network connection.`); + } + core.error(`Download failed from ${info.downloadUrl}. Please check the URl and try again.`); throw err; } const toolPath = yield this.extractArchive(downloadPath, info, true); @@ -100202,8 +100255,9 @@ class BaseDistribution { return { range: valid, options }; } acquireWindowsNodeFromFallbackLocation(version_1) { - return __awaiter(this, arguments, void 0, function* (version, arch = os_1.default.arch()) { + return __awaiter(this, arguments, void 0, function* (version, arch = os_1.default.arch(), downloadUrl) { const initialUrl = this.getDistributionUrl(); + core.info('url: ' + initialUrl); const osArch = this.translateArchToDistUrl(arch); // Create temporary folder to download to const tempDownloadFolder = `temp_${(0, uuid_1.v4)()}`; @@ -100217,6 +100271,9 @@ class BaseDistribution { exeUrl = `${initialUrl}/v${version}/win-${osArch}/node.exe`; libUrl = `${initialUrl}/v${version}/win-${osArch}/node.lib`; core.info(`Downloading only node binary from ${exeUrl}`); + if (downloadUrl != exeUrl) { + core.error('unable to download node binary with the provided URL. Please check and try again'); + } const exePath = yield tc.downloadTool(exeUrl); yield io.cp(exePath, path.join(tempDir, 'node.exe')); const libPath = yield tc.downloadTool(libUrl); @@ -100392,7 +100449,12 @@ class NightlyNodejs extends base_distribution_prerelease_1.default { this.distribution = 'nightly'; } getDistributionUrl() { - return 'https://nodejs.org/download/nightly'; + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } + else { + return 'https://nodejs.org/download/nightly'; + } } } exports["default"] = NightlyNodejs; @@ -100451,73 +100513,93 @@ class OfficialBuilds extends base_distribution_1.default { } setupNodeJs() { return __awaiter(this, void 0, void 0, function* () { - var _a; - let manifest; - let nodeJsVersions; - const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); - if (this.isLtsAlias(this.nodeInfo.versionSpec)) { - core.info('Attempt to resolve LTS alias from manifest...'); - // No try-catch since it's not possible to resolve LTS alias without manifest - manifest = yield this.getManifest(); - this.nodeInfo.versionSpec = this.resolveLtsAliasFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, manifest); - } - if (this.isLatestSyntax(this.nodeInfo.versionSpec)) { - nodeJsVersions = yield this.getNodeJsVersions(); - const versions = this.filterVersions(nodeJsVersions); - this.nodeInfo.versionSpec = this.evaluateVersions(versions); - core.info('getting latest node version...'); - } - if (this.nodeInfo.checkLatest) { - core.info('Attempt to resolve the latest version from manifest...'); - const resolvedVersion = yield this.resolveVersionFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, osArch, manifest); - if (resolvedVersion) { - this.nodeInfo.versionSpec = resolvedVersion; - core.info(`Resolved as '${resolvedVersion}'`); - } - else { - core.info(`Failed to resolve version ${this.nodeInfo.versionSpec} from manifest`); - } - } - let toolPath = this.findVersionInHostedToolCacheDirectory(); - if (toolPath) { - core.info(`Found in cache @ ${toolPath}`); - this.addToolPath(toolPath); - return; - } - let downloadPath = ''; - try { - core.info(`Attempting to download ${this.nodeInfo.versionSpec}...`); - const versionInfo = yield this.getInfoFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, osArch, manifest); - if (versionInfo) { - core.info(`Acquiring ${versionInfo.resolvedVersion} - ${versionInfo.arch} from ${versionInfo.downloadUrl}`); - downloadPath = yield tc.downloadTool(versionInfo.downloadUrl, undefined, this.nodeInfo.auth); + var _a, _b; + if (this.nodeInfo.mirrorURL) { + let downloadPath = ''; + try { + core.info(`Attempting to download using mirror URL...`); + downloadPath = yield this.downloadFromMirrorURL(); // Attempt to download from the mirror + core.info('downloadPath from downloadFromMirrorURL() ' + downloadPath); if (downloadPath) { - toolPath = yield this.extractArchive(downloadPath, versionInfo, false); + const toolPath = downloadPath; } } - else { - core.info('Not found in manifest. Falling back to download directly from Node'); - } - } - catch (err) { - // Rate limit? - if (err instanceof tc.HTTPError && - (err.httpStatusCode === 403 || err.httpStatusCode === 429)) { - core.info(`Received HTTP status code ${err.httpStatusCode}. This usually indicates the rate limit has been exceeded`); - } - else { + catch (err) { core.info(err.message); + core.info('Download failed'); + core.debug((_a = err.stack) !== null && _a !== void 0 ? _a : 'empty stack'); } - core.debug((_a = err.stack) !== null && _a !== void 0 ? _a : 'empty stack'); - core.info('Falling back to download directly from Node'); } - if (!toolPath) { - toolPath = yield this.downloadDirectlyFromNode(); + else { + core.info('No mirror URL found. Falling back to default setup...'); + core.info('Setup Node.js'); + let manifest; + let nodeJsVersions; + const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); + if (this.isLtsAlias(this.nodeInfo.versionSpec)) { + core.info('Attempt to resolve LTS alias from manifest...'); + // No try-catch since it's not possible to resolve LTS alias without manifest + manifest = yield this.getManifest(); + this.nodeInfo.versionSpec = this.resolveLtsAliasFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, manifest); + } + if (this.isLatestSyntax(this.nodeInfo.versionSpec)) { + nodeJsVersions = yield this.getNodeJsVersions(); + const versions = this.filterVersions(nodeJsVersions); + this.nodeInfo.versionSpec = this.evaluateVersions(versions); + core.info('getting latest node version...'); + } + if (this.nodeInfo.checkLatest) { + core.info('Attempt to resolve the latest version from manifest...'); + const resolvedVersion = yield this.resolveVersionFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, osArch, manifest); + if (resolvedVersion) { + this.nodeInfo.versionSpec = resolvedVersion; + core.info(`Resolved as '${resolvedVersion}'`); + } + else { + core.info(`Failed to resolve version ${this.nodeInfo.versionSpec} from manifest`); + } + } + let toolPath = this.findVersionInHostedToolCacheDirectory(); + if (toolPath) { + core.info(`Found in cache @ ${toolPath}`); + this.addToolPath(toolPath); + return; + } + let downloadPath = ''; + try { + core.info(`Attempting to download ${this.nodeInfo.versionSpec}...`); + const versionInfo = yield this.getInfoFromManifest(this.nodeInfo.versionSpec, this.nodeInfo.stable, osArch, manifest); + if (versionInfo) { + core.info(`Acquiring ${versionInfo.resolvedVersion} - ${versionInfo.arch} from ${versionInfo.downloadUrl}`); + downloadPath = yield tc.downloadTool(versionInfo.downloadUrl, undefined, this.nodeInfo.auth); + if (downloadPath) { + toolPath = yield this.extractArchive(downloadPath, versionInfo, false); + } + } + else { + core.info('Not found in manifest. Falling back to download directly from Node'); + } + } + catch (err) { + // Rate limit? + if (err instanceof tc.HTTPError && + (err.httpStatusCode === 403 || err.httpStatusCode === 429)) { + core.info(`Received HTTP status code ${err.httpStatusCode}. This usually indicates the rate limit has been exceeded`); + } + else { + core.info(err.message); + } + core.debug((_b = err.stack) !== null && _b !== void 0 ? _b : 'empty stack'); + core.info('Falling back to download directly from Node'); + } + if (!toolPath) { + toolPath = yield this.downloadDirectlyFromNode(); + } + if (this.osPlat != 'win32') { + toolPath = path_1.default.join(toolPath, 'bin'); + } + core.addPath(toolPath); } - if (this.osPlat != 'win32') { - toolPath = path_1.default.join(toolPath, 'bin'); - } - core.addPath(toolPath); }); } addToolPath(toolPath) { @@ -100559,6 +100641,9 @@ class OfficialBuilds extends base_distribution_1.default { return version; } getDistributionUrl() { + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } return `https://nodejs.org/dist`; } getManifest() { @@ -100626,6 +100711,33 @@ class OfficialBuilds extends base_distribution_1.default { isLatestSyntax(versionSpec) { return ['current', 'latest', 'node'].includes(versionSpec); } + downloadFromMirrorURL() { + return __awaiter(this, void 0, void 0, function* () { + const nodeJsVersions = yield this.getMirrorUrlVersions(); + const versions = this.filterVersions(nodeJsVersions); + const evaluatedVersion = this.evaluateVersions(versions); + if (!evaluatedVersion) { + throw new Error(`Unable to find Node version '${this.nodeInfo.versionSpec}' for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} from the provided mirror-url ${this.nodeInfo.mirrorURL}. Please check the mirror-url`); + } + const toolName = this.getNodejsMirrorURLInfo(evaluatedVersion); + try { + const toolPath = yield this.downloadNodejs(toolName); + return toolPath; + } + catch (error) { + if (error instanceof tc.HTTPError && error.httpStatusCode === 404) { + core.error(`Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` + + 'This usually happens when downloadable binaries are not fully updated at https://nodejs.org/. ' + + 'To resolve this issue you may either fall back to the older version or try again later.'); + } + else { + // For any other error type, you can log the error message. + core.error(`An unexpected error occurred like url might not correct`); + } + throw error; + } + }); + } } exports["default"] = OfficialBuilds; @@ -100647,7 +100759,12 @@ class RcBuild extends base_distribution_1.default { super(nodeInfo); } getDistributionUrl() { - return 'https://nodejs.org/download/rc'; + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } + else { + return 'https://nodejs.org/download/rc'; + } } } exports["default"] = RcBuild; @@ -100671,7 +100788,12 @@ class CanaryBuild extends base_distribution_prerelease_1.default { this.distribution = 'v8-canary'; } getDistributionUrl() { - return 'https://nodejs.org/download/v8-canary'; + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } + else { + return 'https://nodejs.org/download/v8-canary'; + } } } exports["default"] = CanaryBuild; @@ -100748,6 +100870,8 @@ function run() { if (!arch) { arch = os_1.default.arch(); } + const mirrorurl = core.getInput('mirror-url'); + const mirrorURL = (0, util_1.validateMirrorURL)(mirrorurl); if (version) { const token = core.getInput('token'); const auth = !token ? undefined : `token ${token}`; @@ -100758,7 +100882,8 @@ function run() { checkLatest, auth, stable, - arch + arch, + mirrorURL }; const nodeDistribution = (0, installer_factory_1.getNodejsDistribution)(nodejsInfo); yield nodeDistribution.setupNodeJs(); @@ -100852,7 +100977,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) { return (mod && mod.__esModule) ? mod : { "default": mod }; }; Object.defineProperty(exports, "__esModule", ({ value: true })); -exports.unique = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0; +exports.unique = exports.validateMirrorURL = exports.printEnvDetailsAndSetOutput = exports.getNodeVersionFromFile = void 0; const core = __importStar(__nccwpck_require__(2186)); const exec = __importStar(__nccwpck_require__(1514)); const io = __importStar(__nccwpck_require__(7436)); @@ -100940,6 +101065,15 @@ function getToolVersion(tool, options) { } }); } +function validateMirrorURL(mirrorURL) { + if (mirrorURL === ' ' || mirrorURL.trim() === 'undefined') { + throw new Error('Mirror URL is empty. Please provide a valid mirror URL.'); + } + else { + return mirrorURL; + } +} +exports.validateMirrorURL = validateMirrorURL; const unique = () => { const encountered = new Set(); return (value) => { diff --git a/src/distributions/base-distribution.ts b/src/distributions/base-distribution.ts index 70b4b572..2235d28a 100644 --- a/src/distributions/base-distribution.ts +++ b/src/distributions/base-distribution.ts @@ -104,6 +104,31 @@ export default abstract class BaseDistribution { return response.result || []; } + protected async getMirrorUrlVersions(): Promise { + const initialUrl = this.getDistributionUrl(); + + const dataUrl = `${initialUrl}/index.json`; + try { + const response = await this.httpClient.getJson(dataUrl); + return response.result || []; + } catch (err) { + if ( + err instanceof Error && + err.message.includes('getaddrinfo EAI_AGAIN') + ) { + core.error(`Network error: Failed to resolve the server at ${dataUrl}. + Please check your DNS settings or verify that the URL is correct.`); + } else if (err instanceof hc.HttpClientError && err.statusCode === 404) { + core.error(`404 Error: Unable to find versions at ${dataUrl}. + Please verify that the mirror URL is valid.`); + } else { + core.error(`Failed to fetch Node.js versions from ${dataUrl}. + Please check the URL and try again.}`); + } + throw err; + } + } + protected getNodejsDistInfo(version: string) { const osArch: string = this.translateArchToDistUrl(this.nodeInfo.arch); version = semver.clean(version) || ''; @@ -128,6 +153,33 @@ export default abstract class BaseDistribution { }; } + protected getNodejsMirrorURLInfo(version: string) { + const mirrorURL = this.nodeInfo.mirrorURL; + + const osArch: string = this.translateArchToDistUrl(this.nodeInfo.arch); + + version = semver.clean(version) || ''; + const fileName: string = + this.osPlat == 'win32' + ? `node-v${version}-win-${osArch}` + : `node-v${version}-${this.osPlat}-${osArch}`; + const urlFileName: string = + this.osPlat == 'win32' + ? this.nodeInfo.arch === 'arm64' + ? `${fileName}.zip` + : `${fileName}.7z` + : `${fileName}.tar.gz`; + + const url = `${mirrorURL}/v${version}/${urlFileName}`; + + return { + downloadUrl: url, + resolvedVersion: version, + arch: osArch, + fileName: fileName + }; + } + protected async downloadNodejs(info: INodeVersionInfo) { let downloadPath = ''; core.info( @@ -143,9 +195,23 @@ export default abstract class BaseDistribution { ) { return await this.acquireWindowsNodeFromFallbackLocation( info.resolvedVersion, - info.arch + info.arch, + info.downloadUrl ); } + // Handle network-related issues (e.g., DNS resolution failures) + if ( + err instanceof Error && + err.message.includes('getaddrinfo EAI_AGAIN') + ) { + core.error( + `Network error: Failed to resolve the server at ${info.downloadUrl}. + This could be due to a DNS resolution issue. Please verify the URL or check your network connection.` + ); + } + core.error( + `Download failed from ${info.downloadUrl}. Please check the URl and try again.` + ); throw err; } @@ -166,9 +232,11 @@ export default abstract class BaseDistribution { protected async acquireWindowsNodeFromFallbackLocation( version: string, - arch: string = os.arch() + arch: string = os.arch(), + downloadUrl: string ): Promise { const initialUrl = this.getDistributionUrl(); + core.info('url: ' + initialUrl); const osArch: string = this.translateArchToDistUrl(arch); // Create temporary folder to download to @@ -185,6 +253,12 @@ export default abstract class BaseDistribution { core.info(`Downloading only node binary from ${exeUrl}`); + if (downloadUrl != exeUrl) { + core.error( + 'unable to download node binary with the provided URL. Please check and try again' + ); + } + const exePath = await tc.downloadTool(exeUrl); await io.cp(exePath, path.join(tempDir, 'node.exe')); const libPath = await tc.downloadTool(libUrl); diff --git a/src/distributions/base-models.ts b/src/distributions/base-models.ts index 0be93b63..1af61ec8 100644 --- a/src/distributions/base-models.ts +++ b/src/distributions/base-models.ts @@ -4,6 +4,7 @@ export interface NodeInputs { auth?: string; checkLatest: boolean; stable: boolean; + mirrorURL?: string; } export interface INodeVersionInfo { diff --git a/src/distributions/nightly/nightly_builds.ts b/src/distributions/nightly/nightly_builds.ts index 86a89eed..ae0e6265 100644 --- a/src/distributions/nightly/nightly_builds.ts +++ b/src/distributions/nightly/nightly_builds.ts @@ -3,11 +3,16 @@ import {NodeInputs} from '../base-models'; export default class NightlyNodejs extends BasePrereleaseNodejs { protected distribution = 'nightly'; + constructor(nodeInfo: NodeInputs) { super(nodeInfo); } protected getDistributionUrl(): string { - return 'https://nodejs.org/download/nightly'; + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } else { + return 'https://nodejs.org/download/nightly'; + } } } diff --git a/src/distributions/official_builds/official_builds.ts b/src/distributions/official_builds/official_builds.ts index e56eaf81..3d7a2788 100644 --- a/src/distributions/official_builds/official_builds.ts +++ b/src/distributions/official_builds/official_builds.ts @@ -15,115 +15,134 @@ export default class OfficialBuilds extends BaseDistribution { } public async setupNodeJs() { - let manifest: tc.IToolRelease[] | undefined; - let nodeJsVersions: INodeVersion[] | undefined; - const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); + if (this.nodeInfo.mirrorURL) { + let downloadPath = ''; - if (this.isLtsAlias(this.nodeInfo.versionSpec)) { - core.info('Attempt to resolve LTS alias from manifest...'); + try { + core.info(`Attempting to download using mirror URL...`); + downloadPath = await this.downloadFromMirrorURL(); // Attempt to download from the mirror + core.info('downloadPath from downloadFromMirrorURL() ' + downloadPath); + if (downloadPath) { + const toolPath = downloadPath; + } + } catch (err) { + core.info((err as Error).message); + core.info('Download failed'); + core.debug((err as Error).stack ?? 'empty stack'); + } + } else { + core.info('No mirror URL found. Falling back to default setup...'); + core.info('Setup Node.js'); + let manifest: tc.IToolRelease[] | undefined; + let nodeJsVersions: INodeVersion[] | undefined; + const osArch = this.translateArchToDistUrl(this.nodeInfo.arch); - // No try-catch since it's not possible to resolve LTS alias without manifest - manifest = await this.getManifest(); + if (this.isLtsAlias(this.nodeInfo.versionSpec)) { + core.info('Attempt to resolve LTS alias from manifest...'); - this.nodeInfo.versionSpec = this.resolveLtsAliasFromManifest( - this.nodeInfo.versionSpec, - this.nodeInfo.stable, - manifest - ); - } + // No try-catch since it's not possible to resolve LTS alias without manifest + manifest = await this.getManifest(); - if (this.isLatestSyntax(this.nodeInfo.versionSpec)) { - nodeJsVersions = await this.getNodeJsVersions(); - const versions = this.filterVersions(nodeJsVersions); - this.nodeInfo.versionSpec = this.evaluateVersions(versions); - - core.info('getting latest node version...'); - } - - if (this.nodeInfo.checkLatest) { - core.info('Attempt to resolve the latest version from manifest...'); - const resolvedVersion = await this.resolveVersionFromManifest( - this.nodeInfo.versionSpec, - this.nodeInfo.stable, - osArch, - manifest - ); - if (resolvedVersion) { - this.nodeInfo.versionSpec = resolvedVersion; - core.info(`Resolved as '${resolvedVersion}'`); - } else { - core.info( - `Failed to resolve version ${this.nodeInfo.versionSpec} from manifest` + this.nodeInfo.versionSpec = this.resolveLtsAliasFromManifest( + this.nodeInfo.versionSpec, + this.nodeInfo.stable, + manifest ); } - } - let toolPath = this.findVersionInHostedToolCacheDirectory(); + if (this.isLatestSyntax(this.nodeInfo.versionSpec)) { + nodeJsVersions = await this.getNodeJsVersions(); + const versions = this.filterVersions(nodeJsVersions); + this.nodeInfo.versionSpec = this.evaluateVersions(versions); - if (toolPath) { - core.info(`Found in cache @ ${toolPath}`); - this.addToolPath(toolPath); - return; - } + core.info('getting latest node version...'); + } - let downloadPath = ''; - try { - core.info(`Attempting to download ${this.nodeInfo.versionSpec}...`); - - const versionInfo = await this.getInfoFromManifest( - this.nodeInfo.versionSpec, - this.nodeInfo.stable, - osArch, - manifest - ); - - if (versionInfo) { - core.info( - `Acquiring ${versionInfo.resolvedVersion} - ${versionInfo.arch} from ${versionInfo.downloadUrl}` + if (this.nodeInfo.checkLatest) { + core.info('Attempt to resolve the latest version from manifest...'); + const resolvedVersion = await this.resolveVersionFromManifest( + this.nodeInfo.versionSpec, + this.nodeInfo.stable, + osArch, + manifest ); - downloadPath = await tc.downloadTool( - versionInfo.downloadUrl, - undefined, - this.nodeInfo.auth - ); - - if (downloadPath) { - toolPath = await this.extractArchive( - downloadPath, - versionInfo, - false + if (resolvedVersion) { + this.nodeInfo.versionSpec = resolvedVersion; + core.info(`Resolved as '${resolvedVersion}'`); + } else { + core.info( + `Failed to resolve version ${this.nodeInfo.versionSpec} from manifest` ); } - } else { - core.info( - 'Not found in manifest. Falling back to download directly from Node' - ); } - } catch (err) { - // Rate limit? - if ( - err instanceof tc.HTTPError && - (err.httpStatusCode === 403 || err.httpStatusCode === 429) - ) { - core.info( - `Received HTTP status code ${err.httpStatusCode}. This usually indicates the rate limit has been exceeded` - ); - } else { - core.info((err as Error).message); + + let toolPath = this.findVersionInHostedToolCacheDirectory(); + + if (toolPath) { + core.info(`Found in cache @ ${toolPath}`); + this.addToolPath(toolPath); + return; } - core.debug((err as Error).stack ?? 'empty stack'); - core.info('Falling back to download directly from Node'); - } - if (!toolPath) { - toolPath = await this.downloadDirectlyFromNode(); - } + let downloadPath = ''; + try { + core.info(`Attempting to download ${this.nodeInfo.versionSpec}...`); - if (this.osPlat != 'win32') { - toolPath = path.join(toolPath, 'bin'); - } + const versionInfo = await this.getInfoFromManifest( + this.nodeInfo.versionSpec, + this.nodeInfo.stable, + osArch, + manifest + ); - core.addPath(toolPath); + if (versionInfo) { + core.info( + `Acquiring ${versionInfo.resolvedVersion} - ${versionInfo.arch} from ${versionInfo.downloadUrl}` + ); + downloadPath = await tc.downloadTool( + versionInfo.downloadUrl, + undefined, + this.nodeInfo.auth + ); + + if (downloadPath) { + toolPath = await this.extractArchive( + downloadPath, + versionInfo, + false + ); + } + } else { + core.info( + 'Not found in manifest. Falling back to download directly from Node' + ); + } + } catch (err) { + // Rate limit? + if ( + err instanceof tc.HTTPError && + (err.httpStatusCode === 403 || err.httpStatusCode === 429) + ) { + core.info( + `Received HTTP status code ${err.httpStatusCode}. This usually indicates the rate limit has been exceeded` + ); + } else { + core.info((err as Error).message); + } + core.debug((err as Error).stack ?? 'empty stack'); + core.info('Falling back to download directly from Node'); + } + + if (!toolPath) { + toolPath = await this.downloadDirectlyFromNode(); + } + + if (this.osPlat != 'win32') { + toolPath = path.join(toolPath, 'bin'); + } + + core.addPath(toolPath); + } } protected addToolPath(toolPath: string) { @@ -177,6 +196,9 @@ export default class OfficialBuilds extends BaseDistribution { } protected getDistributionUrl(): string { + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } return `https://nodejs.org/dist`; } @@ -291,4 +313,38 @@ export default class OfficialBuilds extends BaseDistribution { private isLatestSyntax(versionSpec): boolean { return ['current', 'latest', 'node'].includes(versionSpec); } + + protected async downloadFromMirrorURL() { + const nodeJsVersions = await this.getMirrorUrlVersions(); + const versions = this.filterVersions(nodeJsVersions); + + const evaluatedVersion = this.evaluateVersions(versions); + + if (!evaluatedVersion) { + throw new Error( + `Unable to find Node version '${this.nodeInfo.versionSpec}' for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} from the provided mirror-url ${this.nodeInfo.mirrorURL}. Please check the mirror-url` + ); + } + + const toolName = this.getNodejsMirrorURLInfo(evaluatedVersion); + + try { + const toolPath = await this.downloadNodejs(toolName); + + return toolPath; + } catch (error) { + if (error instanceof tc.HTTPError && error.httpStatusCode === 404) { + core.error( + `Node version ${this.nodeInfo.versionSpec} for platform ${this.osPlat} and architecture ${this.nodeInfo.arch} was found but failed to download. ` + + 'This usually happens when downloadable binaries are not fully updated at https://nodejs.org/. ' + + 'To resolve this issue you may either fall back to the older version or try again later.' + ); + } else { + // For any other error type, you can log the error message. + core.error(`An unexpected error occurred like url might not correct`); + } + + throw error; + } + } } diff --git a/src/distributions/rc/rc_builds.ts b/src/distributions/rc/rc_builds.ts index 40cdb192..945c270d 100644 --- a/src/distributions/rc/rc_builds.ts +++ b/src/distributions/rc/rc_builds.ts @@ -5,8 +5,11 @@ export default class RcBuild extends BaseDistribution { constructor(nodeInfo: NodeInputs) { super(nodeInfo); } - - getDistributionUrl(): string { - return 'https://nodejs.org/download/rc'; + protected getDistributionUrl(): string { + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } else { + return 'https://nodejs.org/download/rc'; + } } } diff --git a/src/distributions/v8-canary/canary_builds.ts b/src/distributions/v8-canary/canary_builds.ts index 257151b4..53671ace 100644 --- a/src/distributions/v8-canary/canary_builds.ts +++ b/src/distributions/v8-canary/canary_builds.ts @@ -1,6 +1,5 @@ import BasePrereleaseNodejs from '../base-distribution-prerelease'; import {NodeInputs} from '../base-models'; - export default class CanaryBuild extends BasePrereleaseNodejs { protected distribution = 'v8-canary'; constructor(nodeInfo: NodeInputs) { @@ -8,6 +7,10 @@ export default class CanaryBuild extends BasePrereleaseNodejs { } protected getDistributionUrl(): string { - return 'https://nodejs.org/download/v8-canary'; + if (this.nodeInfo.mirrorURL) { + return this.nodeInfo.mirrorURL; + } else { + return 'https://nodejs.org/download/v8-canary'; + } } } diff --git a/src/main.ts b/src/main.ts index c55c3b00..8e53606a 100644 --- a/src/main.ts +++ b/src/main.ts @@ -7,7 +7,11 @@ import * as path from 'path'; import {restoreCache} from './cache-restore'; import {isCacheFeatureAvailable} from './cache-utils'; import {getNodejsDistribution} from './distributions/installer-factory'; -import {getNodeVersionFromFile, printEnvDetailsAndSetOutput} from './util'; +import { + getNodeVersionFromFile, + printEnvDetailsAndSetOutput, + validateMirrorURL +} from './util'; import {State} from './constants'; export async function run() { @@ -33,6 +37,9 @@ export async function run() { arch = os.arch(); } + const mirrorurl = core.getInput('mirror-url'); + const mirrorURL = validateMirrorURL(mirrorurl); + if (version) { const token = core.getInput('token'); const auth = !token ? undefined : `token ${token}`; @@ -45,7 +52,8 @@ export async function run() { checkLatest, auth, stable, - arch + arch, + mirrorURL }; const nodeDistribution = getNodejsDistribution(nodejsInfo); await nodeDistribution.setupNodeJs(); diff --git a/src/util.ts b/src/util.ts index bbe25ddf..232c5db7 100644 --- a/src/util.ts +++ b/src/util.ts @@ -97,7 +97,13 @@ async function getToolVersion(tool: string, options: string[]) { return ''; } } - +export function validateMirrorURL(mirrorURL) { + if (mirrorURL === ' ' || mirrorURL.trim() === 'undefined') { + throw new Error('Mirror URL is empty. Please provide a valid mirror URL.'); + } else { + return mirrorURL; + } +} export const unique = () => { const encountered = new Set(); return (value: unknown): boolean => {