package tools import ( "context" "strings" "testing" "time" "github.com/YspCoder/clawgo/pkg/config" "github.com/YspCoder/clawgo/pkg/nodes" "github.com/YspCoder/clawgo/pkg/runtimecfg" ) func TestSubagentProfileStoreNormalization(t *testing.T) { store := NewSubagentProfileStore(t.TempDir()) saved, err := store.Upsert(SubagentProfile{ AgentID: "Coder Agent", Name: " ", Role: "coding", MemoryNamespace: "My Namespace", ToolAllowlist: []string{" Read_File ", "memory_search", "READ_FILE"}, Status: "ACTIVE", }) if err != nil { t.Fatalf("upsert failed: %v", err) } if saved.AgentID != "coder-agent" { t.Fatalf("unexpected agent_id: %s", saved.AgentID) } if saved.Name != "coder-agent" { t.Fatalf("unexpected default name: %s", saved.Name) } if saved.MemoryNamespace != "my-namespace" { t.Fatalf("unexpected memory namespace: %s", saved.MemoryNamespace) } if len(saved.ToolAllowlist) != 2 { t.Fatalf("unexpected allowlist size: %d (%v)", len(saved.ToolAllowlist), saved.ToolAllowlist) } for _, tool := range saved.ToolAllowlist { if tool != strings.ToLower(tool) { t.Fatalf("tool allowlist should be lowercase, got: %s", tool) } } } func TestSubagentManagerSpawnRejectsDisabledProfile(t *testing.T) { workspace := t.TempDir() manager := NewSubagentManager(nil, workspace, nil) manager.SetRunFunc(func(ctx context.Context, task *SubagentTask) (string, error) { return "ok", nil }) store := manager.ProfileStore() if store == nil { t.Fatalf("expected profile store to be available") } if _, err := store.Upsert(SubagentProfile{ AgentID: "writer", Status: "disabled", }); err != nil { t.Fatalf("failed to seed profile: %v", err) } _, err := manager.Spawn(context.Background(), SubagentSpawnOptions{ Task: "Write docs", AgentID: "writer", OriginChannel: "cli", OriginChatID: "direct", }) if err == nil { t.Fatalf("expected disabled profile to block spawn") } } func TestSubagentManagerSpawnResolvesProfileByRole(t *testing.T) { workspace := t.TempDir() manager := NewSubagentManager(nil, workspace, nil) store := manager.ProfileStore() if store == nil { t.Fatalf("expected profile store to be available") } if _, err := store.Upsert(SubagentProfile{ AgentID: "coder", Role: "coding", Status: "active", ToolAllowlist: []string{"read_file"}, }); err != nil { t.Fatalf("failed to seed profile: %v", err) } _, err := manager.Spawn(context.Background(), SubagentSpawnOptions{ Task: "Implement feature", Role: "coding", OriginChannel: "cli", OriginChatID: "direct", }) if err != nil { t.Fatalf("spawn failed: %v", err) } tasks := manager.ListTasks() if len(tasks) != 1 { t.Fatalf("expected one task, got %d", len(tasks)) } task := tasks[0] if task.AgentID != "coder" { t.Fatalf("expected agent_id to resolve to profile agent_id 'coder', got: %s", task.AgentID) } if task.Role != "coding" { t.Fatalf("expected task role to remain 'coding', got: %s", task.Role) } if len(task.ToolAllowlist) != 1 || task.ToolAllowlist[0] != "read_file" { t.Fatalf("expected allowlist from profile, got: %v", task.ToolAllowlist) } _ = waitSubagentDone(t, manager, 4*time.Second) } func TestSubagentProfileStoreReadsProfilesFromRuntimeConfig(t *testing.T) { runtimecfg.Set(config.DefaultConfig()) t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) }) cfg := config.DefaultConfig() cfg.Agents.Subagents["coder"] = config.SubagentConfig{ Enabled: true, DisplayName: "Code Agent", Role: "coding", SystemPromptFile: "agents/coder/AGENT.md", MemoryNamespace: "code-ns", Tools: config.SubagentToolsConfig{ Allowlist: []string{"read_file", "shell"}, }, Runtime: config.SubagentRuntimeConfig{ MaxRetries: 2, RetryBackoffMs: 2000, TimeoutSec: 120, MaxTaskChars: 4096, MaxResultChars: 2048, }, } runtimecfg.Set(cfg) store := NewSubagentProfileStore(t.TempDir()) profile, ok, err := store.Get("coder") if err != nil { t.Fatalf("get failed: %v", err) } if !ok { t.Fatalf("expected config-backed profile") } if profile.ManagedBy != "config.json" { t.Fatalf("expected config ownership, got: %s", profile.ManagedBy) } if profile.Name != "Code Agent" || profile.Role != "coding" { t.Fatalf("unexpected profile fields: %+v", profile) } if profile.SystemPromptFile != "agents/coder/AGENT.md" { t.Fatalf("expected system_prompt_file from config, got: %s", profile.SystemPromptFile) } if len(profile.ToolAllowlist) != 2 { t.Fatalf("expected merged allowlist, got: %v", profile.ToolAllowlist) } } func TestSubagentProfileStoreRejectsWritesForConfigManagedProfiles(t *testing.T) { runtimecfg.Set(config.DefaultConfig()) t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) }) cfg := config.DefaultConfig() cfg.Agents.Subagents["tester"] = config.SubagentConfig{ Enabled: true, Role: "test", SystemPromptFile: "agents/tester/AGENT.md", } runtimecfg.Set(cfg) store := NewSubagentProfileStore(t.TempDir()) if _, err := store.Upsert(SubagentProfile{AgentID: "tester"}); err == nil { t.Fatalf("expected config-managed upsert to fail") } if err := store.Delete("tester"); err == nil { t.Fatalf("expected config-managed delete to fail") } } func TestSubagentProfileStoreIncludesNodeMainBranchProfiles(t *testing.T) { runtimecfg.Set(config.DefaultConfig()) t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) nodes.DefaultManager().Remove("edge-dev") }) cfg := config.DefaultConfig() cfg.Agents.Router.Enabled = true cfg.Agents.Router.MainAgentID = "main" cfg.Agents.Subagents["main"] = config.SubagentConfig{ Enabled: true, Type: "router", SystemPromptFile: "agents/main/AGENT.md", } runtimecfg.Set(cfg) nodes.DefaultManager().Upsert(nodes.NodeInfo{ ID: "edge-dev", Name: "Edge Dev", Online: true, Agents: []nodes.AgentInfo{ {ID: "main", DisplayName: "Main Agent", Role: "orchestrator", Type: "router"}, {ID: "coder", DisplayName: "Code Agent", Role: "code", Type: "worker"}, }, Capabilities: nodes.Capabilities{ Model: true, }, }) store := NewSubagentProfileStore(t.TempDir()) profile, ok, err := store.Get(nodeBranchAgentID("edge-dev")) if err != nil { t.Fatalf("get failed: %v", err) } if !ok { t.Fatalf("expected node-backed profile") } if profile.ManagedBy != "node_registry" || profile.Transport != "node" || profile.NodeID != "edge-dev" { t.Fatalf("unexpected node profile: %+v", profile) } if profile.ParentAgentID != "main" { t.Fatalf("expected main parent agent, got %+v", profile) } childProfile, ok, err := store.Get("node.edge-dev.coder") if err != nil { t.Fatalf("get child profile failed: %v", err) } if !ok { t.Fatalf("expected child node-backed profile") } if childProfile.ManagedBy != "node_registry" || childProfile.Transport != "node" || childProfile.NodeID != "edge-dev" { t.Fatalf("unexpected child node profile: %+v", childProfile) } if childProfile.ParentAgentID != "node.edge-dev.main" { t.Fatalf("expected child profile to attach to remote main, got %+v", childProfile) } if _, err := store.Upsert(SubagentProfile{AgentID: profile.AgentID}); err == nil { t.Fatalf("expected node-managed upsert to fail") } if err := store.Delete(profile.AgentID); err == nil { t.Fatalf("expected node-managed delete to fail") } } func TestSubagentProfileStoreExcludesLocalNodeMainBranchProfile(t *testing.T) { runtimecfg.Set(config.DefaultConfig()) t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) nodes.DefaultManager().Remove("local") }) cfg := config.DefaultConfig() cfg.Agents.Router.Enabled = true cfg.Agents.Router.MainAgentID = "main" cfg.Agents.Subagents["main"] = config.SubagentConfig{ Enabled: true, Type: "router", SystemPromptFile: "agents/main/AGENT.md", } runtimecfg.Set(cfg) nodes.DefaultManager().Upsert(nodes.NodeInfo{ ID: "local", Name: "Local", Online: true, }) store := NewSubagentProfileStore(t.TempDir()) if profile, ok, err := store.Get(nodeBranchAgentID("local")); err != nil { t.Fatalf("get failed: %v", err) } else if ok { t.Fatalf("expected local node branch profile to be excluded, got %+v", profile) } items, err := store.List() if err != nil { t.Fatalf("list failed: %v", err) } for _, item := range items { if item.AgentID == nodeBranchAgentID("local") { t.Fatalf("local node branch profile should not appear in list") } } }