Add multi-agent config and registry runtime flow

pkg/agent/runtime_admin_test.go

@@ -0,0 +1,314 @@
+package agent
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"clawgo/pkg/config"
+	"clawgo/pkg/runtimecfg"
+	"clawgo/pkg/tools"
+)
+
+func TestHandleSubagentRuntimeDispatchAndWait(t *testing.T) {
+	workspace := t.TempDir()
+	manager := tools.NewSubagentManager(nil, workspace, nil, nil)
+	manager.SetRunFunc(func(ctx context.Context, task *tools.SubagentTask) (string, error) {
+		return "runtime-admin-result", nil
+	})
+	loop := &AgentLoop{
+		subagentManager: manager,
+		subagentRouter:  tools.NewSubagentRouter(manager),
+	}
+
+	out, err := loop.HandleSubagentRuntime(context.Background(), "dispatch_and_wait", map[string]interface{}{
+		"task":             "implement runtime action",
+		"agent_id":         "coder",
+		"channel":          "webui",
+		"chat_id":          "webui",
+		"wait_timeout_sec": float64(5),
+	})
+	if err != nil {
+		t.Fatalf("dispatch_and_wait failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok {
+		t.Fatalf("unexpected payload type: %T", out)
+	}
+	reply, ok := payload["reply"].(*tools.RouterReply)
+	if !ok {
+		t.Fatalf("expected router reply, got %T", payload["reply"])
+	}
+	if reply.Status != "completed" || reply.Result != "runtime-admin-result" {
+		t.Fatalf("unexpected reply: %+v", reply)
+	}
+	merged, _ := payload["merged"].(string)
+	if merged == "" {
+		t.Fatalf("expected merged output")
+	}
+}
+
+func TestHandleSubagentRuntimeUpsertConfigSubagent(t *testing.T) {
+	workspace := t.TempDir()
+	configPath := filepath.Join(workspace, "config.json")
+	cfg := config.DefaultConfig()
+	cfg.Agents.Router.Enabled = true
+	cfg.Agents.Subagents["main"] = config.SubagentConfig{
+		Enabled: true,
+		Type:    "router",
+		Role:    "orchestrator",
+	}
+	if err := config.SaveConfig(configPath, cfg); err != nil {
+		t.Fatalf("save config failed: %v", err)
+	}
+	runtimecfg.Set(cfg)
+	t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) })
+
+	manager := tools.NewSubagentManager(nil, workspace, nil, nil)
+	loop := &AgentLoop{
+		configPath:      configPath,
+		subagentManager: manager,
+		subagentRouter:  tools.NewSubagentRouter(manager),
+	}
+	out, err := loop.HandleSubagentRuntime(context.Background(), "upsert_config_subagent", map[string]interface{}{
+		"agent_id":         "reviewer",
+		"role":             "testing",
+		"display_name":     "Review Agent",
+		"system_prompt":    "review changes",
+		"routing_keywords": []interface{}{"review", "regression"},
+		"tool_allowlist":   []interface{}{"shell", "sessions"},
+	})
+	if err != nil {
+		t.Fatalf("upsert config subagent failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok || payload["ok"] != true {
+		t.Fatalf("unexpected payload: %#v", out)
+	}
+	reloaded, err := config.LoadConfig(configPath)
+	if err != nil {
+		t.Fatalf("reload config failed: %v", err)
+	}
+	subcfg, ok := reloaded.Agents.Subagents["reviewer"]
+	if !ok || subcfg.DisplayName != "Review Agent" {
+		t.Fatalf("expected reviewer subagent in config, got %+v", reloaded.Agents.Subagents)
+	}
+	if len(reloaded.Agents.Router.Rules) == 0 {
+		t.Fatalf("expected router rules to be persisted")
+	}
+	data, err := os.ReadFile(configPath)
+	if err != nil || len(data) == 0 {
+		t.Fatalf("expected config file to be written")
+	}
+}
+
+func TestHandleSubagentRuntimeDraftConfigSubagent(t *testing.T) {
+	manager := tools.NewSubagentManager(nil, t.TempDir(), nil, nil)
+	loop := &AgentLoop{
+		subagentManager: manager,
+		subagentRouter:  tools.NewSubagentRouter(manager),
+	}
+	out, err := loop.HandleSubagentRuntime(context.Background(), "draft_config_subagent", map[string]interface{}{
+		"description": "创建一个负责回归测试和验证修复结果的子代理",
+	})
+	if err != nil {
+		t.Fatalf("draft config subagent failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok {
+		t.Fatalf("unexpected payload type: %T", out)
+	}
+	draft, ok := payload["draft"].(map[string]interface{})
+	if !ok {
+		t.Fatalf("expected draft payload, got %#v", payload["draft"])
+	}
+	if draft["role"] == "" || draft["agent_id"] == "" {
+		t.Fatalf("expected draft role and agent_id, got %#v", draft)
+	}
+}
+
+func TestHandleSubagentRuntimePendingDraftsAndClear(t *testing.T) {
+	manager := tools.NewSubagentManager(nil, t.TempDir(), nil, nil)
+	loop := &AgentLoop{
+		subagentManager:      manager,
+		subagentRouter:       tools.NewSubagentRouter(manager),
+		pendingSubagentDraft: map[string]map[string]interface{}{"main": {"agent_id": "tester", "role": "testing"}},
+	}
+
+	out, err := loop.HandleSubagentRuntime(context.Background(), "pending_drafts", nil)
+	if err != nil {
+		t.Fatalf("pending drafts failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok {
+		t.Fatalf("unexpected payload type: %T", out)
+	}
+	items, ok := payload["items"].([]map[string]interface{})
+	if !ok || len(items) != 1 {
+		t.Fatalf("expected one pending draft, got %#v", payload["items"])
+	}
+
+	out, err = loop.HandleSubagentRuntime(context.Background(), "clear_pending_draft", map[string]interface{}{"session_key": "main"})
+	if err != nil {
+		t.Fatalf("clear pending draft failed: %v", err)
+	}
+	payload, ok = out.(map[string]interface{})
+	if !ok || payload["ok"] != true {
+		t.Fatalf("unexpected clear payload: %#v", out)
+	}
+	if loop.loadPendingSubagentDraft("main") != nil {
+		t.Fatalf("expected pending draft to be cleared")
+	}
+}
+
+func TestHandleSubagentRuntimeConfirmPendingDraft(t *testing.T) {
+	workspace := t.TempDir()
+	configPath := filepath.Join(workspace, "config.json")
+	cfg := config.DefaultConfig()
+	cfg.Agents.Router.Enabled = true
+	cfg.Agents.Subagents["main"] = config.SubagentConfig{
+		Enabled: true,
+		Type:    "router",
+		Role:    "orchestrator",
+	}
+	if err := config.SaveConfig(configPath, cfg); err != nil {
+		t.Fatalf("save config failed: %v", err)
+	}
+	runtimecfg.Set(cfg)
+	t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) })
+
+	manager := tools.NewSubagentManager(nil, workspace, nil, nil)
+	loop := &AgentLoop{
+		configPath:           configPath,
+		subagentManager:      manager,
+		subagentRouter:       tools.NewSubagentRouter(manager),
+		pendingSubagentDraft: map[string]map[string]interface{}{"main": {"agent_id": "tester", "role": "testing", "type": "worker"}},
+	}
+	out, err := loop.HandleSubagentRuntime(context.Background(), "confirm_pending_draft", map[string]interface{}{"session_key": "main"})
+	if err != nil {
+		t.Fatalf("confirm pending draft failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok || payload["ok"] != true {
+		t.Fatalf("unexpected confirm payload: %#v", out)
+	}
+	reloaded, err := config.LoadConfig(configPath)
+	if err != nil {
+		t.Fatalf("reload config failed: %v", err)
+	}
+	if _, ok := reloaded.Agents.Subagents["tester"]; !ok {
+		t.Fatalf("expected tester subagent to be persisted")
+	}
+}
+
+func TestHandleSubagentRuntimeRegistryAndToggleEnabled(t *testing.T) {
+	workspace := t.TempDir()
+	configPath := filepath.Join(workspace, "config.json")
+	cfg := config.DefaultConfig()
+	cfg.Agents.Router.Enabled = true
+	cfg.Agents.Subagents["main"] = config.SubagentConfig{
+		Enabled: true,
+		Type:    "router",
+		Role:    "orchestrator",
+	}
+	cfg.Agents.Subagents["tester"] = config.SubagentConfig{
+		Enabled:         true,
+		Type:            "worker",
+		Role:            "testing",
+		DisplayName:     "Test Agent",
+		SystemPrompt:    "run tests",
+		MemoryNamespace: "tester",
+		Tools: config.SubagentToolsConfig{
+			Allowlist: []string{"shell", "sessions"},
+		},
+	}
+	cfg.Agents.Router.Rules = []config.AgentRouteRule{{AgentID: "tester", Keywords: []string{"test", "regression"}}}
+	if err := config.SaveConfig(configPath, cfg); err != nil {
+		t.Fatalf("save config failed: %v", err)
+	}
+	runtimecfg.Set(cfg)
+	t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) })
+
+	manager := tools.NewSubagentManager(nil, workspace, nil, nil)
+	loop := &AgentLoop{
+		configPath:      configPath,
+		subagentManager: manager,
+		subagentRouter:  tools.NewSubagentRouter(manager),
+	}
+	out, err := loop.HandleSubagentRuntime(context.Background(), "registry", nil)
+	if err != nil {
+		t.Fatalf("registry failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok {
+		t.Fatalf("unexpected registry payload: %T", out)
+	}
+	items, ok := payload["items"].([]map[string]interface{})
+	if !ok || len(items) < 2 {
+		t.Fatalf("expected registry items, got %#v", payload["items"])
+	}
+
+	_, err = loop.HandleSubagentRuntime(context.Background(), "set_config_subagent_enabled", map[string]interface{}{
+		"agent_id": "tester",
+		"enabled":  false,
+	})
+	if err != nil {
+		t.Fatalf("toggle enabled failed: %v", err)
+	}
+	reloaded, err := config.LoadConfig(configPath)
+	if err != nil {
+		t.Fatalf("reload config failed: %v", err)
+	}
+	if reloaded.Agents.Subagents["tester"].Enabled {
+		t.Fatalf("expected tester to be disabled")
+	}
+}
+
+func TestHandleSubagentRuntimeDeleteConfigSubagent(t *testing.T) {
+	workspace := t.TempDir()
+	configPath := filepath.Join(workspace, "config.json")
+	cfg := config.DefaultConfig()
+	cfg.Agents.Router.Enabled = true
+	cfg.Agents.Subagents["main"] = config.SubagentConfig{
+		Enabled: true,
+		Type:    "router",
+		Role:    "orchestrator",
+	}
+	cfg.Agents.Subagents["tester"] = config.SubagentConfig{
+		Enabled: true,
+		Type:    "worker",
+		Role:    "testing",
+	}
+	cfg.Agents.Router.Rules = []config.AgentRouteRule{{AgentID: "tester", Keywords: []string{"test"}}}
+	if err := config.SaveConfig(configPath, cfg); err != nil {
+		t.Fatalf("save config failed: %v", err)
+	}
+	runtimecfg.Set(cfg)
+	t.Cleanup(func() { runtimecfg.Set(config.DefaultConfig()) })
+
+	manager := tools.NewSubagentManager(nil, workspace, nil, nil)
+	loop := &AgentLoop{
+		configPath:      configPath,
+		subagentManager: manager,
+		subagentRouter:  tools.NewSubagentRouter(manager),
+	}
+	out, err := loop.HandleSubagentRuntime(context.Background(), "delete_config_subagent", map[string]interface{}{"agent_id": "tester"})
+	if err != nil {
+		t.Fatalf("delete config subagent failed: %v", err)
+	}
+	payload, ok := out.(map[string]interface{})
+	if !ok || payload["ok"] != true {
+		t.Fatalf("unexpected delete payload: %#v", out)
+	}
+	reloaded, err := config.LoadConfig(configPath)
+	if err != nil {
+		t.Fatalf("reload config failed: %v", err)
+	}
+	if _, ok := reloaded.Agents.Subagents["tester"]; ok {
+		t.Fatalf("expected tester to be removed")
+	}
+	if len(reloaded.Agents.Router.Rules) != 0 {
+		t.Fatalf("expected tester route rule to be removed")
+	}
+}